Fix buffer overrun in ConvertAudio with different src/dst channel count #12064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Source or destination format also has to not be F32 to trigger bug
|
Does this fix all broken cutscenes or just the intro? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To trigger this bug, the source and destination channel count have to not match, and the source format also has to not be f32.
Description
This fixes a buffer overrun (and intermittent crash) when playing audio from the opening FMV of Bloodborne in the ShadPS4 emulator. That audio is in 8 channel, s16le format, which triggers an audio conversion code path that probably isn't very common.
Existing Issue(s)
shadps4-emu/shadPS4#2034